Rename outer enums to RuntimeCall, RuntimeEvent, etc

[kianenigma]

we should really just rename the Call generated by the construct_runtime! to RuntimeCall.

Originally posted by @kianenigma in #8458 (comment)

• Call
• Event
• Origin

---

See confusions such as https://substrate.stackexchange.com/questions/3360/using-scheduler-pallet-to-schedule-contract-pallet-call

[KiChjang]

As mentioned in the PR, I don't really like the idea of naming it OuterCall, as it implies that there's an "inner" call, and it's not obvious what it is.

However, based on discussions, we have settled upon naming them RuntimeCalls and PalletCalls. These two names should be self-explanatory about what they refer to.

[tifecool]

I'd like to pick up this issue. Would I have to work in-depth with macros?

[shawntabrizi]

@tifecool yes you can pick it up

I don't think you will need to work deeply, but you will need to adjust some of the enum names generated by the macros.

Ideally, we could support the old enum name with some backwards compatibility config

[kianenigma]

@KiChjang will you be working on this?

[KiChjang]

I could if it's urgent, otherwise other people can pick this up if they're interested.

[kianenigma]

yeah was just wondering since we talked about it in person. Nah, I don't think it is urgent and it is a good first-issue for other contributors to FRAME.

[tifecool]

Couldn't figure out where to change the Calls. I don't mind someone else picking the issue up. Would be nice to see the solution

Edit: Still attempting, but if someone else takes it it's fine.

[Szegoo]

Couldn't figure out where to change the Calls. I don't mind someone else picking the issue up. Would be nice to see the solution

Edit: Still attempting, but if someone else takes it it's fine.

Have you managed to get it working? If not I will probably make a PR. I believe that the files that need to be modified are: frame/support/procedural/src/construct_runtime/expand/call.rs and frame/support/procedural/src/construct_runtime/expand/event.rs

[tifecool]

I believe that the files that need to be modified are: frame/support/procedural/src/construct_runtime/expand/call.rs and frame/support/procedural/src/construct_runtime/expand/event.rs

Hey @Szegoo. Funny enough just figured that out yesterday hence the "Still attempting" edit. Now I'm getting the error:
error[E0433]: failed to resolve: use of undeclared type "Call"

Dropping the issue now. Please go ahead 😇️

Edit: If you run into the same issue would love to know how you worked it out. I think having a way to see where exactly the macro tries to use "Call" would be very helpful.

[Szegoo]

@tifecool Sorry, I didn't notice the "Still attempting" edit. Feel free to continue working on this if you want to, I didn't want to make any pressure on you. If you really want to drop this issue, I would be happy to work on this.

[tifecool]

@Szegoo It's no pressure. You're welcome to work on it. I'll learn from your solution.

[kianenigma]

We could probably use a small PR for origin at some point too?

[Szegoo]

We could probably use a small PR for origin at some point too?

I will open a new PR for that.

[Szegoo]

Shouldn't this issue be closed?

[KiChjang]

Yes.

[shredding]

Please update the documentation as well. It'll save the next dev after me hours of frustration.