Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

make MAX_VOTERS and MAX_CANDIDATES in elections-phragmen configurable #11902

Closed
kianenigma opened this issue Jul 25, 2022 · 2 comments · Fixed by #11908
Closed

make MAX_VOTERS and MAX_CANDIDATES in elections-phragmen configurable #11902

kianenigma opened this issue Jul 25, 2022 · 2 comments · Fixed by #11908
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Jul 25, 2022 •
edited
Loading

Make these two magic constants added in #11790 be type X: Get<_>, set them to the same value as now in the polkadot companion. Document that parachain teams should chose these values carefully, ensuring that both the weight and PoV is within reason.
@kianenigma kianenigma added J0-enhancement An additional feature request. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Jul 25, 2022
@kianenigma
Copy link
Contributor Author

@Szegoo interested?

@Szegoo
Copy link
Contributor

Szegoo commented Jul 25, 2022

@Szegoo interested?

Yes.

@sudipghimire533 sudipghimire533 mentioned this issue Jul 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make MAX_VOTERS and MAX_CANDIDATES in elections-phragmen configurable. Fix: #11092
2 participants
@kianenigma @Szegoo