This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove all bespoke implementations of preimage-lookup #12070
Labels
I7-refactor
Code needs refactoring.
Comments
@ggwpez I don't think there's any changes needed to be made here, but could you check through all production pallets and make sure we're not doing this anywhere? |
I want to work on this |
I think we have to tackle paritytech/polkadot-sdk#323, otherwise we have no guarantee that all storage items are bound. |
related: #12821 |
@ggwpez would be good to close this - I suspect there are no further preimage lookups happening in the pallets, but would be good to confirm this and close. |
Yes AFAIK we got all of them. Looking at the storage sizes of each pallet confirms this.
(the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Avoid all unbounded preimage lookups since they are at risk from PoV-bloat-attack. Instead, use Preimages pallet,
QueryPreimage
/StorePreimage
traits andBounded<T>
.Calls
(can have this functionality removed for simplicity).The text was updated successfully, but these errors were encountered: