Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Deprecation] Deprecate decl_* macros #12248

Closed
KiChjang opened this issue Sep 13, 2022 · 6 comments
Closed

[Deprecation] Deprecate decl_* macros #12248

KiChjang opened this issue Sep 13, 2022 · 6 comments
Assignees
@ggwpez
Labels
I7-refactor Code needs refactoring. T1-runtime This PR/Issue is related to the topic “runtime”. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@KiChjang
Copy link
Contributor

KiChjang commented Sep 13, 2022 •
edited
Loading

We've now basically migrated from the previous function-like decl_* macros into the #[pallet] attribute macros, and it's time that we start deprecating/removing the old decl_ macros.
@KiChjang KiChjang added I7-refactor Code needs refactoring. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Sep 13, 2022
@KiChjang KiChjang mentioned this issue Sep 13, 2022
Merged
@koushiro koushiro mentioned this issue Sep 15, 2022
Merged
@kianenigma kianenigma moved this to Backlog in Runtime / FRAME Sep 15, 2022
@yourarj
Copy link

yourarj commented Sep 17, 2022

@KiChjang I would like to take it up.

@koushiro koushiro mentioned this issue Sep 22, 2022
Closed
This was referenced Oct 3, 2022
Merged
Merged
@kianenigma kianenigma moved this from Backlog to To Do in Runtime / FRAME Mar 10, 2023
@ggwpez
Copy link
Member

ggwpez commented Mar 15, 2023

There are two merge requests leading up to this #12401 and #12445 which are both stale&closed.
Maybe someone can give this another nudge? The old macros still pollute the code base.

@kziemianek kziemianek mentioned this issue Mar 15, 2023
Merged
@ggwpez ggwpez mentioned this issue Mar 24, 2023
Merged
@kianenigma kianenigma mentioned this issue Aug 24, 2023
Open
@juangirini juangirini changed the title Deprecate decl_* macros [Deprecation] Deprecate decl_* macros Apr 24, 2023
@ggwpez ggwpez mentioned this issue Apr 28, 2023
Closed
@juangirini
Copy link
Contributor

The deprecated Module type alias for Pallet should also be removed

@juangirini juangirini moved this from To Do to In progress in Runtime / FRAME May 5, 2023
@juangirini juangirini added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jun 7, 2023
@ggwpez
Copy link
Member

ggwpez commented Jun 15, 2023

The deprecated Module type alias for Pallet should also be removed

I am not familiar with this, but looks like it already is deprecated?! Since two years actually…

substrate/frame/support/procedural/src/pallet/expand/pallet_struct.rs

Line 197 in 9ffd3d7

#[deprecated(note = "use `Pallet` instead")]

@juangirini
Copy link
Contributor

I am not familiar with this, but looks like it already is deprecated?! Since two years actually…

Yes, it's already time to remove it :)

@ggwpez
Copy link
Member

ggwpez commented Jun 16, 2023 •
edited
Loading

Okay so closing his and creating another one for removal.

@ggwpez ggwpez closed this as completed Jun 16, 2023
@github-project-automation github-project-automation bot moved this from Draft to Closed in Parity Roadmap Jun 16, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Runtime / FRAME Jun 16, 2023
@ggwpez ggwpez mentioned this issue Jun 16, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ggwpez ggwpez

Labels
I7-refactor Code needs refactoring. T1-runtime This PR/Issue is related to the topic “runtime”. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate decl_* macros
4 participants
@KiChjang @juangirini @ggwpez @yourarj