Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Utility.batch_all wrapped in Proxy is not transactional #12306

Closed
2 tasks done
mclyk opened this issue Sep 20, 2022 · 2 comments
Closed
2 tasks done

Utility.batch_all wrapped in Proxy is not transactional #12306

mclyk opened this issue Sep 20, 2022 · 2 comments
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@mclyk
Copy link

mclyk commented Sep 20, 2022

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

In this PR: #11431,
the macro #[transactional] has been removed from 'utility.batch_all', it works good normally, however if it's wrapped in Proxy.proxy, there is an issue:

suppose a transaction like this:
Proxy.proxy<Utility.batch_all<call1,call2,call3>>

  • call1: system. remarkWithEvent
  • call2: balance.transfer(1 trillion)
  • call3: system. remarkWithEvent

if send this transaction to on-chain, call2 failed but call1 success.

Steps to reproduce

on-chain proxy transaction:

https://polkadot.js.org/apps/?rpc=wss://rpc.polkadot.io#/explorer/query/0xfe8aded7fc1380da895e90d046acf55c6e51fe0939c0b8b93d9c477156a97931

https://polkadot.polkaholic.io/tx/0xb437c0237cba48e4eec12dffbe19bdec9305c5df7a4365f861f8c1303b664436

@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Sep 20, 2022
@kianenigma kianenigma moved this to Backlog in Runtime / FRAME Sep 20, 2022
@shawntabrizi
Copy link
Member

Assuming you are on the latest master, these kinds of issues should be resolved starting here: #11927

@mclyk
Copy link
Author

mclyk commented Sep 21, 2022

Got it, thanks.

@mclyk mclyk closed this as completed Sep 21, 2022
Repository owner moved this from Backlog to Done in Runtime / FRAME Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
Status: Done
Development

No branches or pull requests

2 participants