Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove *_old_weight extrinsic after migration to extrinsics with new Weight struct is complete #12377

Closed
2 tasks
KiChjang opened this issue Sep 28, 2022 · 1 comment
Labels
I7-refactor Code needs refactoring.

Comments

@KiChjang
Copy link
Contributor

KiChjang commented Sep 28, 2022

In #12277, we created new extrinsics that utilizes the new 2D Weight struct as part of its parameters, and deprecated those that still uses the old Weight struct. The deprecated extrinsics are renamed and they all end with _old_weight. We have chosen this method of migration because we want to allow downstream dependencies to still be able to decode into the deprecated calls, but warn upon calling them.

The migration strategy we have for now is to allow downstream dependencies to call the deprecated extrinsics, and allow them to migrate to the new ones. After a certain length of time, we should however work towards:

  • Removing the OldWeight struct
  • Completely remove the deprecated extrinsics while ensuring that we keep the extrinsic indices unchanged (can be done using the #[pallet::call_index] attribute).
@KiChjang KiChjang added the I7-refactor Code needs refactoring. label Sep 28, 2022
@ggwpez
Copy link
Member

ggwpez commented Apr 27, 2023

Both tasks completed for all FRAME pallets in #13699.
Contracts need to support V1 indefinitely - issue does therenot apply there.

@ggwpez ggwpez closed this as completed Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring.
Projects
Status: Done
Development

No branches or pull requests

2 participants