You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Since we're changing the pallet-mmr runtime & RPC APIs as part of #12339 it's a good opportunity to revisit some other decisions related to the API:
Whether we should have 2 separate methods generate_batch_proof() and generate_historical_batch_proof(). Since in the end generate_batch_proof() is a special case of generate_historical_batch_proof(). See the discussion here: pallet-mmr: generate historical proofs #12324 (comment)
If we should keep generate_proof(), verify_proof(), and verify_proof_stateless() since all these can be done via batching methods (e.g. generate_batch_proof(), etc)
I agree with unifying all, but drop "batching" or "historical" from new "universal" API name, should be simple generate_proof(), verify_proof(), and verify_proof_stateless() with optional extra params.
Documentation should also be very clear to explain specific param combinations.
I agree with unifying all, but drop "batching" or "historical" from new "universal" API name, should be simple generate_proof(), verify_proof(), and verify_proof_stateless() with optional extra params.
Documentation should also be very clear to explain specific param combinations.
ditto: I support unification, and if unified, then batching & historical qualifiers are superfluous and should be dropped.
Sounds good ! I also agree with this naming scheme.
acatangiu
changed the title
pallet-mmr: Discuss reducing the number of methods in runtime API and RPC API
pallet-mmr: Consolidate/deduplicate methods in runtime API and RPC API
Oct 3, 2022
Since we're changing the pallet-mmr runtime & RPC APIs as part of #12339 it's a good opportunity to revisit some other decisions related to the API:
generate_batch_proof()
andgenerate_historical_batch_proof()
. Since in the endgenerate_batch_proof()
is a special case ofgenerate_historical_batch_proof()
. See the discussion here: pallet-mmr: generate historical proofs #12324 (comment)cc: @acatangiu @Lederstrumpf @svyatonik
The text was updated successfully, but these errors were encountered: