This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
pallet-mmr: Consolidate/deduplicate methods in runtime API and RPC API #12391
Labels
Comments
I agree with unifying all, but drop "batching" or "historical" from new "universal" API name, should be simple generate_proof(), verify_proof(), and verify_proof_stateless() with optional extra params. |
acatangiu
added
I7-refactor
Code needs refactoring.
U2-some_time_soon
Issue is worth doing soon.
labels
Oct 3, 2022
ditto: I support unification, and if unified, then batching & historical qualifiers are superfluous and should be dropped. |
Sounds good ! I also agree with this naming scheme. |
acatangiu
changed the title
pallet-mmr: Discuss reducing the number of methods in runtime API and RPC API
pallet-mmr: Consolidate/deduplicate methods in runtime API and RPC API
Oct 3, 2022
This was referenced Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Since we're changing the pallet-mmr runtime & RPC APIs as part of #12339 it's a good opportunity to revisit some other decisions related to the API:
generate_batch_proof()
andgenerate_historical_batch_proof()
. Since in the endgenerate_batch_proof()
is a special case ofgenerate_historical_batch_proof()
. See the discussion here: pallet-mmr: generate historical proofs #12324 (comment)cc: @acatangiu @Lederstrumpf @svyatonik
The text was updated successfully, but these errors were encountered: