Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Fix] try_state in BagsList needs to be feature-gated and the signature has to adhere to that in Hooks. #13293

Closed
ruseinov opened this issue Feb 1, 2023 · 2 comments · Fixed by #13296
Assignees
Labels
J0-enhancement An additional feature request.

Comments

@ruseinov
Copy link
Contributor

ruseinov commented Feb 1, 2023

The current BagsList implementation does not feature-gate try_state and nor does it have an argument for block number.

As a consequence a bunch of other pallets/tests are calling a variety of try_state methods outside of try-runtime context. What this means is we need to feature gate all the instances of try_state related to BagsList pallet and make sure we have a decent substitute to call within tests/benchmarks, similar to do_try_state in staking pallet.

@ruseinov ruseinov added the J0-enhancement An additional feature request. label Feb 1, 2023
@ruseinov ruseinov self-assigned this Feb 1, 2023
@kianenigma
Copy link
Contributor

Please chose the right "domain" part in the project as well :)

@ruseinov ruseinov moved this from 📕 Backlog to ✂️ In progress. in (Nominated) Proof of Stake Feb 9, 2023
@github-project-automation github-project-automation bot moved this from ✂️ In progress. to ✅ Done in (Nominated) Proof of Stake Feb 9, 2023
@ruseinov
Copy link
Contributor Author

ruseinov commented Feb 9, 2023

Please chose the right "domain" part in the project as well :)

Yep, the github UI was hiding this under a grey link + 1 more so I was always missing it. Lesson learned :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants