Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

try-runtime can panic when RPC requests fail #13695

Closed
liamaharon opened this issue Mar 23, 2023 · 2 comments
Closed

try-runtime can panic when RPC requests fail #13695

liamaharon opened this issue Mar 23, 2023 · 2 comments
Assignees
@liamaharon
Labels
U3-nice_to_have Issue is worth doing eventually. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@liamaharon
Copy link
Contributor

liamaharon commented Mar 23, 2023 •
edited
Loading

If a node doesn't answer RPC requests correctly (for example if --rpc-max-response-size or --rpc-max-request-size are not configured correctly) then it panics and logs a nasty output.

Rather than panicing, the cli should exit gracefully and suggest to the user that they check their node config.
@liamaharon liamaharon added Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder I1-panic The node panics and exits without proper error handling. U3-nice_to_have Issue is worth doing eventually. labels Mar 23, 2023
@ggwpez
Copy link
Member

ggwpez commented Mar 23, 2023 •
edited
Loading

The batch error in particular can be fixed by #13562.

PS: The try-runtime-cli panics, not the node 😉

@ggwpez ggwpez removed the I1-panic The node panics and exits without proper error handling. label Mar 23, 2023
@liamaharon liamaharon self-assigned this Mar 31, 2023
@liamaharon liamaharon changed the title try-runtime follow-chain can panic when RPC requests fail try-runtime can panic when RPC requests fail Mar 31, 2023
@liamaharon liamaharon mentioned this issue Apr 14, 2023
Merged
4 tasks
@liamaharon
Copy link
Contributor Author

Closing in favor of #13246

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@liamaharon liamaharon

Labels
U3-nice_to_have Issue is worth doing eventually. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggwpez @liamaharon