Add GitHub handle to pallet-identity

[ggwpez]

(I cant find an issue in case this was already proposed)

Would be nice to have GitHub handles in the identity data. Especially with the Polkadot fellowship being so reliant on it.
They are automatically verifiable by registrates via edited profile text, so no problem.

[bkchr]

We can just add the github handle the to the additional fields?

substrate/frame/identity/src/types.rs

Line 293 in 6ef33ad

pub additional: BoundedVec<(Data, Data), FieldLimit>,

[ggwpez]

We can just add the github handle the to the additional fields?

Yes but registrats cannot verify that since it is "custom" data, so the interpretation of it is not defined.

[ggwpez]

For example one person writes "Github handle", the next "github" and so on. Its probably easier to extend the enum since we have Twitter and Riot it is already opinionated.

[bkchr]

For example one person writes "Github handle", the next "github" and so on.

Yes, but then you need to specify what kind of key is the correct one.

Its probably easier to extend the enum since we have Twitter and Riot it is already opinionated.

I would argue that this should not have been done and it should have been generic from the beginning.

[ggwpez]

I would argue that this should not have been done and it should have been generic from the beginning.

Yea probably better to start with this. Then we can inject the "custom" type via the config trait.

[bkchr]

Closing in favor of: paritytech/polkadot-sdk#179