Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use default config trait in mock runtimes #14336

Closed
ggwpez opened this issue Jun 9, 2023 · 4 comments
Closed

Use default config trait in mock runtimes #14336

ggwpez opened this issue Jun 9, 2023 · 4 comments
Assignees
Labels
I5-tests Tests need fixing, improving or augmenting. I7-refactor Code needs refactoring. T1-runtime This PR/Issue is related to the topic “runtime”.

Comments

@ggwpez
Copy link
Member

ggwpez commented Jun 9, 2023

Would be good if we start using the default config trait from #13454 to ensure that we covered most use-cases. For example in all mock.rs files on frame_system and maybe also pallet-balances.
Now we can still make some adjustments before more downstream projects start using it.
cc @juangirini

(This brings me to the idea that we could have a nightly or unstable module in frame-support, where we throw stuff in that has not been battle tested.)

@ggwpez ggwpez added I5-tests Tests need fixing, improving or augmenting. I7-refactor Code needs refactoring. T1-runtime This PR/Issue is related to the topic “runtime”. labels Jun 9, 2023
@juangirini juangirini self-assigned this Jun 9, 2023
@kianenigma
Copy link
Contributor

Isn't this one item in paritytech/polkadot-sdk#171?

@juangirini
Copy link
Contributor

It looks like a good candidate for a sub issue of the tracking one

@kianenigma
Copy link
Contributor

Still seems like the list of pallets I have in #14453 :D

@ggwpez
Copy link
Member Author

ggwpez commented Jun 24, 2023

yea, duplicate.

@ggwpez ggwpez closed this as completed Jun 24, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I5-tests Tests need fixing, improving or augmenting. I7-refactor Code needs refactoring. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
Development

No branches or pull requests

3 participants