Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Replace error-chain #1547

Closed
bkchr opened this issue Jan 24, 2019 · 1 comment · Fixed by #2662
Closed

Replace error-chain #1547

bkchr opened this issue Jan 24, 2019 · 1 comment · Fixed by #2662
Assignees
@tomaka
Labels
I7-refactor Code needs refactoring.
Milestone
Ideas

Comments

@bkchr
Copy link
Member

bkchr commented Jan 24, 2019

With the latest nightlies, rust spits out a warning about using a deprecated method of the Error trait. See here for more information.
As error-chain is in maintenance mode and its unlikely that there will be any real new stuff, we should watch out for what is the new way of error reporting in rust. (Failure probably already failed).
@bkchr bkchr added the I7-refactor Code needs refactoring. label Jan 24, 2019
@bkchr bkchr added this to the As-and-when milestone Jan 24, 2019
@tomaka
Copy link
Contributor

tomaka commented Jan 25, 2019

we should watch out for what is the new way of error reporting in rust.

Implementing the Error trait manually on an enum has always worked and has no risk of suffering from maintenance mode.

This was referenced Feb 28, 2019
Merged
Merged
@ascjones ascjones mentioned this issue Apr 8, 2019
Merged
@kianenigma kianenigma mentioned this issue Apr 13, 2019
Merged
@tomaka tomaka self-assigned this May 22, 2019
@ascjones ascjones mentioned this issue May 22, 2019
Merged
@tomusdrw tomusdrw mentioned this issue May 22, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomaka tomaka

Labels
I7-refactor Code needs refactoring.
Projects
None yet
Milestone
Ideas
Development

Successfully merging a pull request may close this issue.

Expunge error-chain (feat. tomaka) paritytech/substrate
2 participants
@tomaka @bkchr