Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Replace slog with log once log supports structured logging #3260

Closed
tomaka opened this issue Jul 30, 2019 · 4 comments
Closed

Replace slog with log once log supports structured logging #3260

tomaka opened this issue Jul 30, 2019 · 4 comments
Labels
I7-refactor Code needs refactoring.
Milestone

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 30, 2019

The entirety of Substrate uses the log crate, except for the telemetry which uses slog because of structured logging.

The log is currently getting support for structured logging:
rust-lang/log#149
rust-lang/log#328

Once this is done, we can switch out from slog.

@tomaka tomaka added the I7-refactor Code needs refactoring. label Jul 30, 2019
@tomaka tomaka added this to the The Distant Future milestone Jul 30, 2019
@yoshuawuyts
Copy link

https://github.com/yoshuawuyts/kv-log-macro now works, which coupled with the kv_unstable macro should probably cover most of what you might want from a logging solution (:

@gnunicorn
Copy link
Contributor

We're using slog just to have a global logger and to serialize json, we could replace it with serde_json and lazy_static

@gnunicorn gnunicorn modified the milestones: The Distant Future, 2.0 Dec 6, 2019
@tomaka
Copy link
Contributor Author

tomaka commented Dec 6, 2019

If someone tackles this issue, please add me as a reviewer.

@gnunicorn gnunicorn modified the milestones: 2.0, The Distant Future Dec 9, 2019
@gnunicorn gnunicorn modified the milestones: The Distant Future, Ideas Mar 4, 2020
@bkchr
Copy link
Member

bkchr commented Apr 15, 2021

Telemetry isn't using slog anymore.

@bkchr bkchr closed this as completed Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Development

No branches or pull requests

4 participants