Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Transaction Weight mechanism not considering proposals #3921

Closed
xlc opened this issue Oct 26, 2019 · 3 comments
Closed

Transaction Weight mechanism not considering proposals #3921

xlc opened this issue Oct 26, 2019 · 3 comments
Assignees
Labels
I3-bug The node fails to follow expected behavior.

Comments

@xlc
Copy link
Contributor

xlc commented Oct 26, 2019

Disaptchable calls can be dispatched indirectly (and many of them are designed to be dispatched indirectly, such as system::set_code). The transaction weight for those indirects calls are not considered at all right now.

e.g. collective::vote is FixedOperational(200_000) and may dispatch an arbitrary proposal, such as membership::add_member which is FixedNormal(50_000). The final weight for such transaction should be 250_000 instead of ignoring the weight of membership::add_member.

Related: #3730 can make dynamically increase weight possible when the proposal is dispatched.

@kianenigma kianenigma self-assigned this Oct 26, 2019
@kianenigma
Copy link
Contributor

kianenigma commented Oct 27, 2019

related to #3730

also @sorpaas I think you will need the same thing for EVM, right? in this sense, proposals, srml-contracts and srml-evm are quite similar, they all have some inner code that needs to be accounted for post-dispatch.

@sorpaas
Copy link
Member

sorpaas commented Oct 27, 2019

Yeah I think it's related to EVM module as well.

@xlc
Copy link
Contributor Author

xlc commented Jun 26, 2020

I think this is fixed already.

@xlc xlc closed this as completed Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug The node fails to follow expected behavior.
Projects
None yet
Development

No branches or pull requests

4 participants