Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Events should be chucked #5466

Closed
kianenigma opened this issue Mar 31, 2020 · 6 comments
Closed

Events should be chucked #5466

kianenigma opened this issue Mar 31, 2020 · 6 comments
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Mar 31, 2020 •
edited
Loading

All events are stored under a single key. retrieving this potentially huge blob of data for cases such as account creation in genesis, or other potentially blocks that are bloated with lots of events, is a rocksdb killer; events should be chucked into smaller maps of vectors. See the elections pallet for a reference of this.
@kianenigma kianenigma added the I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. label Mar 31, 2020
@bkchr
Copy link
Member

bkchr commented Mar 31, 2020

#5463

I think this is the better solution.

@kianenigma
Copy link
Contributor Author

I know about the PR but from the internal discussion I understood that we want the chunking as well anyhow. Maybe I misunderstood?

@kianenigma
Copy link
Contributor Author

related #2619

@bkchr
Copy link
Member

bkchr commented Apr 8, 2020

I still don't see how this should improve the performance. This increases the amount of storage accesses and we will not see 100k events.

@kianenigma
Copy link
Contributor Author

Yeah this issue is subject to doubt. Yet I think the implementation of the abstraction is good feature to provide anyhow.

@bkchr
Copy link
Member

bkchr commented Apr 9, 2020

The abstraction is a completely different topic^^

@kianenigma kianenigma added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kianenigma @bkchr