Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Post Weights Checklist #6040

Closed
2 of 7 tasks
shawntabrizi opened this issue May 14, 2020 · 4 comments
Closed
2 of 7 tasks

Post Weights Checklist #6040

shawntabrizi opened this issue May 14, 2020 · 4 comments

Comments

@shawntabrizi
Copy link
Member

shawntabrizi commented May 14, 2020

Here are some things that we should do once initial weights are "completed" (see #5596)

  • Write down all changed APIs to pallets (additional parameters, additional traits, etc)

  • Write down all changed functionality to pallets (new functions? functions do different things?)

  • Write down all assumptions about maximums taken in weight calculations.

  • Double check all weights one last time (sanity check)

  • Ensure Polkadot JS API is updated for changed APIs and Functionality

  • Check operational dispatches if they should be operational, and check if any new dispatches can be operational.

  • Make sure we can save a blockchain with full blocks using only operational transactions. (Allow operational recovery path if on_initialize use fullblock. #6089)

@joepetrowski
Copy link
Contributor

@kianenigma
Copy link
Contributor

  • move all weights to saturating_xxx.

@apopiak
Copy link
Contributor

apopiak commented May 15, 2020

  • collect open questions regarding future weight work (e.g. "how to do transitive weights well?", "how to help others building with substrate to do weights well?")

@gui1117
Copy link
Contributor

gui1117 commented May 20, 2020

move all weights to saturating_xxx.

an option could also be to use a type which saturate by itself, std provides, https://doc.rust-lang.org/core/num/struct.Wrapping.html
Somebody implemented https://crates.io/crates/saturating
Though I think manual saturation is fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants