-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add an alternative to sc-network-gossip for parachains #6583
Comments
Not all of the protocols for Parachains networking are gossip protocols. And actually, many that are currently gossip protocols, we would prefer not to be as there would be major efficiency gains to be made by having validators communicate via direct messaging.
Because of that, all of the backpressure work on networking can happen behind the scenes, from the Parachains codebase perspective. It would make most sense to me to focus on refactoring the network service to make Behind the scenes one layer down in libp2p we would want to be dropping peers who are not accepting messages fast enough, which, as I understand it, has not actually been a problem in practice. |
I'm going to close this issue as it's unclear what exactly to do. |
Address points (1) and (2) of paritytech/polkadot#1348
We can add a crate similar to
sc-network-gossip
, except that it keeps track of the number of valid/invalid messages for each peer and pulls messages at a slower rate for peers whose ratio is too low.The slower pulling rate should in turn apply back-pressure on the connection, and force the sending side to slow down the sending rate.
"Stops processing messages" requires some modifications to the API of
sc-network
in addition to paritytech/polkadot-sdk#554. paritytech/polkadot-sdk#554 itself depends on #5938.Not strictly-speaking concerned by this issue, but related: #5481 will cause issues on the sending side if we back-pressure the connection.
The text was updated successfully, but these errors were encountered: