You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Here are some identified problems to fix for end to end benchmarking automation with the bot:
Keep the weight function signature consistent. It shouldnt be that someone runs the benchmarks, and that the function signature is inconsistent causing the branch to not compile. Constant Weight Signature in Benchmarking CLI #7233
Substrate node weights should probably just reference the "default weights" since they are literally the same file. This means we dont need to maintain 2 sets of files. Use Handlebars Template for Benchmark CLI Output #7390
We should probably get rid of impl WeightInfo for () in favor of impl WeightInfo for SubstrateDefault<T> or something, which would ensure that we are always using the DbWeight as defined in Runtime. Use Handlebars Template for Benchmark CLI Output #7390
WeightInfo trait definition should live in the same file as the outputted weights, which means that if the signature DOES change, it will automatically be updated together with the new weights. User would still ultimately need to update the node. Use Handlebars Template for Benchmark CLI Output #7390
Create allow output to work for both the crate definition and the runtime definition. For example in the crate it will need to refer to crate::WeightInfo while in the runtime it needs to refer to pallet_name::WeightInfo. Use Handlebars Template for Benchmark CLI Output #7390
Additionally:
Clean CLI command for getting list of pallets and benchmarks available.
Auto add benchmark tests to tests.
The text was updated successfully, but these errors were encountered:
Here are some identified problems to fix for end to end benchmarking automation with the bot:
impl WeightInfo for ()
in favor ofimpl WeightInfo for SubstrateDefault<T>
or something, which would ensure that we are always using the DbWeight as defined in Runtime. Use Handlebars Template for Benchmark CLI Output #7390WeightInfo
trait definition should live in the same file as the outputted weights, which means that if the signature DOES change, it will automatically be updated together with the new weights. User would still ultimately need to update the node. Use Handlebars Template for Benchmark CLI Output #7390default_weights.rs
to justweights.rs
when it has more things like the trait definition. Use Handlebars Template for Benchmark CLI Output #7390crate::WeightInfo
while in the runtime it needs to refer topallet_name::WeightInfo
. Use Handlebars Template for Benchmark CLI Output #7390Additionally:
The text was updated successfully, but these errors were encountered: