Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add variant of state_subscribeStorage that waits for changes to be finalized #8273

Open
gregdhill opened this issue Mar 4, 2021 · 1 comment
Open

Add variant of state_subscribeStorage that waits for changes to be finalized #8273

gregdhill opened this issue Mar 4, 2021 · 1 comment
Labels
A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@gregdhill
Copy link

gregdhill commented Mar 4, 2021 •
edited
Loading

Currently, subxt uses state_subscribeStorage to listen for and decode events but this is unsafe because downstream clients may react to discarded events if the underlying block is forked. I have implemented a workaround here but it would be nice to embed such functionality directly in Substrate.
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Mar 4, 2021
@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregdhill