Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sc-rpc still on futures 1.x #8381

Closed
Voxelot opened this issue Mar 16, 2021 · 6 comments
Closed

sc-rpc still on futures 1.x #8381

Voxelot opened this issue Mar 16, 2021 · 6 comments
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@Voxelot
Copy link

Voxelot commented Mar 16, 2021

Please upgrade sc-rpc to the latest version of https://github.com/paritytech/jsonrpc 17.0.0.

Currently all the exported generated rpc clients in sc-rpc are still on futures 1.x. It looks like upgrading to jsonrpc 17.0.0 will fix this.

@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Mar 16, 2021
@Voxelot
Copy link
Author

Voxelot commented Mar 16, 2021

@kianenigma
Copy link
Contributor

cc @tomusdrw

I faced issues with this myself and having to deal with two versions of tokio runtime within one codebase was a bit of a hassle.

@tomusdrw
Copy link
Contributor

It's a known issue and we are working on fixing this. AFAIK the solution that we've settled on is jsonrpsee integration. CC @dvdplm @gnunicorn.

@Voxelot
Copy link
Author

Voxelot commented Mar 18, 2021

jsonrpsee integration makes sense, are there any issues I could follow to be notified of when the migration is complete? #3099 hasn't seen an update for over a year :/

Depending on how far out that is, would it be less of a hassle in the near term to just bump the versions to jsonrpc 17.0.0 as it is already on tokio 0.2? Then I could go back to using #[tokio::test] and #[tokio::main] instead of tokio_compat :D

@dvdplm
Copy link
Contributor

dvdplm commented Mar 18, 2021

The work to migrate substrate off jsonrpc and switch to jsonrpsee happens here and work is under way. The client is further along than the server though and substrate-integration is at the PoC-level still. It's looking good though and we expect fairly rapid progress on this over the coming months.

I believe @gnunicorn made an attempt to upgrade to jsonrpc v17 as a stop-gap solution for the painful tokio situation but found it to be less than trivial.

@Voxelot
Copy link
Author

Voxelot commented Mar 19, 2021

Really appreciate all the info. I'm going to close this issue for now since it's not really actionable until the re-write of jsonrpc is complete.

@Voxelot Voxelot closed this as completed Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Development

No branches or pull requests

4 participants