You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
shaunxw opened this issue
Mar 19, 2021
· 1 comment
· Fixed by #8407
Labels
Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coderZ6-mentorAn easy task where a mentor is available. Please indicate in the issue who the mentor could be.
IMHO it needs be fixed as in general variables should be the same. It could cause troubles while doing equal assertion. Like in ORML unit tests, when a event contains DispatchError, comparing the built even in test function with System::events() results unexpected unequal, unless with a manual conversion like here.
The text was updated successfully, but these errors were encountered:
This is done by intention, because we don't want to store the message on chain.
I'm open to accept a pr that changes the PartialEq to ignore message.
shawntabrizi
added
Z1-easy
Can be fixed primarily by duplicating and adapting code by an intermediate coder
Z6-mentor
An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
labels
Mar 19, 2021
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coderZ6-mentorAn easy task where a mentor is available. Please indicate in the issue who the mentor could be.
If we have a
DispatchError::Module
variant like this:After encoding and then decoding, it will become different:
IMHO it needs be fixed as in general variables should be the same. It could cause troubles while doing equal assertion. Like in ORML unit tests, when a event contains
DispatchError
, comparing the built even in test function withSystem::events()
results unexpected unequal, unless with a manual conversion like here.The text was updated successfully, but these errors were encountered: