Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Tests are failing on 1.54.0 stable toolchain #9627

Closed
rcny opened this issue Aug 25, 2021 · 6 comments · Fixed by #9637
Closed

Tests are failing on 1.54.0 stable toolchain #9627

rcny opened this issue Aug 25, 2021 · 6 comments · Fixed by #9637

Comments

@rcny
Copy link
Contributor

rcny commented Aug 25, 2021

Hi!

ci-linux:production image, which is used in Substrate and related projects pipelines, is stuck with rustc 1.53.0 (53cb7b09b 2021-06-17) due to failing tests on the recent stable. Here is failing test job example with staging image bundled with rustc 1.54.0 (a178d0322 2021-07-26).

I'm unable to gracefully promote current staging images into production images. Doing so forcefully will break stuff as in the example above.

@rcny rcny added the I3-bug The node fails to follow expected behavior. label Aug 25, 2021
@rcny
Copy link
Contributor Author

rcny commented Aug 25, 2021

Fails on the fresh master too:
test-linux-stable
test-wasmer-sandbox

@gui1117
Copy link
Contributor

gui1117 commented Aug 26, 2021

the failing test are UI tests, I think those tests are not relevant for your case, maybe we should introduce a feature to be able not to run them. like feature disable-ui-test.
Would that solve your issue ?

@rcny
Copy link
Contributor Author

rcny commented Aug 26, 2021

I can add some switches (e.g. add an environment variable to all jobs if a pipeline was triggered from a nightly build), but doing so will branch the project's CI/CD pipeline into two separate entities:

  • Original production pipeline
  • Staging pipeline with some tweaks so the image can be released automatically

IMO that's pointless. Staging has to be production-like and simulate a production run. If those would differ, the current staging activity (build a staging image and trigger a Substrate's pipeline with it) will make no sense.

@bkchr bkchr removed the I3-bug The node fails to follow expected behavior. label Aug 27, 2021
@gui1117
Copy link
Contributor

gui1117 commented Aug 27, 2021

sorry, I missunderstood, I thought we were using 1.54 in CI and you wanted to run test for an old image with 1.53.
Then yes we must update the test result with the version change

@ordian
Copy link
Member

ordian commented Sep 10, 2021

FYI: rust 1.55 is out: https://blog.rust-lang.org/2021/09/09/Rust-1.55.0.html, can we go straight to 1.55?

@bkchr
Copy link
Member

bkchr commented Sep 11, 2021

Yeah, probably a good idea :D

@ghost ghost closed this as completed in #9637 Sep 24, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants