Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update .maintain/Dockerfile #9765

Closed
TriplEight opened this issue Sep 13, 2021 · 2 comments · Fixed by #9808
Closed

Update .maintain/Dockerfile #9765

TriplEight opened this issue Sep 13, 2021 · 2 comments · Fixed by #9808
Assignees

Comments

@TriplEight
Copy link
Contributor

A follow-up from #9753

is it still used?

Yes, and it is critical to keep it.

if yes, it should follow our containers policy and use ubuntu:20.04 as base

I see no issue with that. Do you want to include that in the PR? If not, please open an issue and I will take care of it.

and have some metadata as the other images do

100%

Originally posted by @chevdor in #9753 (comment)

@chevdor chevdor self-assigned this Sep 13, 2021
@chevdor
Copy link
Contributor

chevdor commented Sep 17, 2021

  • add metadata
  • use ubuntu:20.04 as base
  • add label io.parity.image.type="builder"
  • remove labels not relevant to images not built via CI
  • align the entrypoint with the injected image
  • align the volumes with the injected image
  • fix exposed ports

@chevdor
Copy link
Contributor

chevdor commented Sep 17, 2021

See also paritytech/polkadot#3884

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants