Use proper intra doc links for macro generated code

[gui1117]

doc like

substrate/frame/support/procedural/src/construct_runtime/expand/origin.rs

Line 160 in 62f011c

/// Create with system none origin and `frame-system::Config::BaseCallFilter`.

doesn't link to the item.

We should make a correct item link.

[zh-beep]

@thiolliere - I'm currently learning Rust and would like to contribute, would I be able to help with this issue?

[gui1117]

in the example in the top message instead of frame-system::Config::BaseCallFilter we should have a doc link so something like

[`frame_system::Config::BaseCallFilter`]

But because frame_system crate can be renamed in the Cargo.toml we should get the correct name. So at the end the doc generated might look like:

///  Create with system none origin and `[
#[doc = #frame_system]
/// ::Config::BaseCallFilter`]

I'm not sure it works or maybe otherwise:

///  Create with system none origin and 
#[doc = #doc_item]
/// .

I mean I don't really know the implementation but at the end it should have the correct link when we generate the doc with cargo doc.

[dharjeezy]

Is this issue done? @thiolliere can I pick the issue up?

[gui1117]

anybody can submit a PR which solve this issue, they can also ping my name on the PR top message.

On master I still see those which could have a intra doc link:

frame/support/procedural/src/construct_runtime/expand/origin.rs:185:			/// Create with system none origin and `frame-system::Config::BaseCallFilter`.
frame/support/procedural/src/construct_runtime/expand/origin.rs:189:			/// Create with system root origin and `frame-system::Config::BaseCallFilter`.
frame/support/procedural/src/construct_runtime/expand/origin.rs:193:			/// Create with system signed origin and `frame-system::Config::BaseCallFilter`.
frame/support/procedural/src/construct_runtime/expand/origin.rs:219:			/// Convert to runtime origin, using as filter: `frame-system::Config::BaseCallFilter`.
frame/support/procedural/src/construct_runtime/expand/origin.rs:251:			/// `frame-system::Config::BaseCallFilter`.
frame/support/procedural/src/construct_runtime/expand/origin.rs:314:			/// Convert to runtime origin using `frame-system::Config::BaseCallFilter`.
frame/support/procedural/src/construct_runtime/expand/origin.rs:78:		/// Origin is always created with the base filter configured in `frame_system::Config::BaseCallFilter`.

[dharjeezy]

can you check the PR i created @thiolliere

[dharjeezy]

@thiolliere i have updated the PR i opened. could you take a look now.

[KiChjang]

Fixed by #10271.