Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subxt-codegen: support web and fetch-metadata together? Tidy web. #1169

Closed
jsdw opened this issue Sep 20, 2023 · 0 comments · Fixed by #1175
Closed

subxt-codegen: support web and fetch-metadata together? Tidy web. #1169

jsdw opened this issue Sep 20, 2023 · 0 comments · Fixed by #1175
Assignees

Comments

@jsdw
Copy link
Collaborator

jsdw commented Sep 20, 2023

#1154 makes subxt-codegen play nicely in WASM. It currently does this by simply hiding all of the jsonrpsee related bits behind a fetch-metadata feature. This feature isn't compatible with the web feature that is also added at the moment.

Since jsonrpsee can be compiled to WASM, we could support fetch-metadata and web together if we wanted.

Secondly, if subxt has its web feature enabled, we should ensure to enable the web feature in subxt-codegen too, just so that subxt-codegen knows to handle this. (easiest way might just be to have a web feature in subxt-macro which jsut enables it in subxt-codegen, and then in subxt we have web = [..., "subxt-macro/web"].

This isn't very pressing, since everything works as-is right now; just a nice to have to consistify things a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants