Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve our signed extension / ExtrinsicParams examples #1314

Closed
jsdw opened this issue Dec 7, 2023 · 0 comments · Fixed by #1357
Closed

Docs: Improve our signed extension / ExtrinsicParams examples #1314

jsdw opened this issue Dec 7, 2023 · 0 comments · Fixed by #1357

Comments

@jsdw
Copy link
Collaborator

jsdw commented Dec 7, 2023

Currently, we have two examples related to these:

https://docs.rs/subxt/0.33.0/subxt/book/setup/config/index.html#implementing-and-adding-new-signed-extensions-to-the-config

and

https://docs.rs/subxt/0.33.0/subxt/book/setup/config/index.html#implementing-crateconfigextrinsicparams-from-scratch

The first example is OK I think, but the second example conflates two things; creating a custom ExtrinsicParams implementation, and using MultiLocation based AssetIds for the ChargeAssetTxPayment signed extension.

I think we should:

  1. Remove the MultiLocation stuff from the second example.
  2. Add a third example which is dedicated specifically to using the generated MultiLocation (which is something chains like asset hub require if you want to be able to pay tips when submitting extrinsics).

@bee344 we've beenb chatting about this in the Subxt Lounge; I thought it best to make a proper issue for it so that it's not lost! You're welcome to have a go at this (or we can discuss alternatives here), or else I'm sure we'll get around to addressing it in the new year :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant