Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for events.rs/decode_and_consume_type #414

Closed
jsdw opened this issue Jan 27, 2022 · 1 comment
Closed

Add more tests for events.rs/decode_and_consume_type #414

jsdw opened this issue Jan 27, 2022 · 1 comment
Labels
good first issue Small, well scoped, simple; good for newcomers

Comments

@jsdw
Copy link
Collaborator

jsdw commented Jan 27, 2022

#408 did a little refactoring which made decode_and_consume_type easier to test in isolation. decode_bitvec is an example of such a test. It would be lovely to test some of the other branches of that function more thoroughly in a similar way. There might also be some scope to simplify a few of the existing tests.

(from #408 (comment))
@jsdw jsdw added the good first issue Small, well scoped, simple; good for newcomers label Jan 27, 2022
@jsdw jsdw changed the title Write more tests for events.rs/decode_and_consume_type Add more tests for events.rs/decode_and_consume_type Jan 27, 2022
@jsdw jsdw mentioned this issue Feb 1, 2022
Closed
16 tasks
@lexnv lexnv mentioned this issue Feb 3, 2022
Merged
@jsdw
Copy link
Collaborator Author

jsdw commented Feb 4, 2022

Closed by #430

@jsdw jsdw closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Small, well scoped, simple; good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsdw