Flaky non_finalized_block_subscription test

[lexnv]

Test events::non_finalized_block_subscription sometimes fails.

---- events::non_finalized_block_subscription stdout ----
thread 'events::non_finalized_block_subscription' panicked at 'assertion failed: `(left != right)`
  left: `0xac78c5c5e978bc952fd5a408bf9b3945083b361de222ac4a08f739d333da79b1`,
 right: `0xac78c5c5e978bc952fd5a408bf9b3945083b361de222ac4a08f739d333da79b1`', subxt/tests/integration/events.rs:43:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[jsdw]

Hmm perhaps the test as-is is a bit crappy; it assumes that the latest block it obtains is never finalised, but much like the subscription_produces_events_each_block test which sometimes finds a block 0 with no events at all, I wonder whether this test needs to also be OK with block 0 being finalized as well, if it is fast enough to get handed block 0 back.

[dvdplm]

Do you think this is a good excuse to try out https://nexte.st/ in CI? :)

[jsdw]

Do you think this is a good excuse to try out https://nexte.st/ in CI? :)

Ooh; I saw the PR to try it in jsonrpsee so I'll be curious to see how much difference it makes there (I guess you have to weigh the cost of installing the tool versus the gain in speed from running it). I'd rather avoid flaky tests entirely if possible so that bit isn't so useful to me :D