Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerated code uses different libraries for H160 vs H256 #619

Closed
luketchang opened this issue Aug 14, 2022 · 0 comments · Fixed by #623
Closed

Autogenerated code uses different libraries for H160 vs H256 #619

luketchang opened this issue Aug 14, 2022 · 0 comments · Fixed by #623

Comments

@luketchang
Copy link

luketchang commented Aug 14, 2022 •
edited
Loading

When autogenerating bindings for pallet structs that use primitive_types::H160 and primitive_types::H256 subxt codegen ends up using different libraries for H160 vs H256 in the generated code.

subxt generated code shows the following when running cargo expand:

  • H160: runtime_types::primitive_types::H160
  • H256: ::subxt::sp_core::H256

The fact that codegen uses primitive_types for H160 and sp_core for H256 is causing type conflicts. Would like for both to use sp_core instead.
@luketchang luketchang changed the title Autogenerated code uses different libraries for H160 and H256 Autogenerated code uses different libraries for H160 vsH256 Aug 14, 2022
@luketchang luketchang changed the title Autogenerated code uses different libraries for H160 vsH256 Autogenerated code uses different libraries for H160 vs H256 Aug 14, 2022
@jsdw jsdw mentioned this issue Aug 17, 2022
Merged
@jsdw jsdw closed this as completed in #623 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use 'sp_core::Hxxx' for all hash types paritytech/subxt
1 participant
@luketchang