Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create raw payload from rpc client #82

Closed
whalelephant opened this issue Mar 30, 2020 · 6 comments
Closed

Create raw payload from rpc client #82

whalelephant opened this issue Mar 30, 2020 · 6 comments

Comments

@whalelephant
Copy link
Contributor

Hi,
I would like to get feedback on a proposed method for Client such that
client.create_raw_payload(AccountId, Call) returns the payload to be signed.

The reason is so that the payload may be signed by other signers (maybe not in the XtBuilder and use this or other tools to create uncheckedExtrinsic.

@ascjones
Copy link
Contributor

Sounds like a good idea, though perhaps it would be on the XtBuilder API?

@whalelephant
Copy link
Contributor Author

From my understanding Xtbuilder currently accept a signer type with trait Pair implemented for signing. The proposed method is so that the only requirement for creating the raw payload is the pubkey / account ID

@ascjones
Copy link
Contributor

Yeah you're right. Potentially could make signer Option<P> then provide an XtBuilder impl with P = (). But feel free to make a PR with your idea, and we can see how it looks.

@whalelephant
Copy link
Contributor Author

ok cool, I don't have permission to push my working branch for the PR at the moment. Please help. thanks!

@ascjones
Copy link
Contributor

ascjones commented Apr 1, 2020

If you have a fork you should be able to push to that and create a PR from there

@ascjones
Copy link
Contributor

ascjones commented Apr 9, 2020

Closed in #83

@ascjones ascjones closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants