Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #180
rel: #126
This fixes a bug introduced in #178 where an increased effort to sanitize numbers via
toTxMethod
was given, this makes sure we check the type of the primitive value as well as!Number.isNaN
to ensure any integer that makes it past the first initial sanitization is converted to a string.I also added a test suite for
toTxMethod
(long over due).I can also confirm with the given test the older logic was failing and is now passing.