Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additionalTypes, and typesBundle to getRegistryBase #294

Merged
merged 5 commits into from
May 5, 2023

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented May 4, 2023

closes: #286

Summary

This allows for two new keys in the getRegistryBase function for injecting types to the registry.

  1. typesBundle: for adding OverrideBundleTypes to the knownTypes of the registry.

  2. additionalTypes: for registering any custom types you wish to construct that are not included in the specTypes field.

Affected Function

@substrate/txwrapper-polkadot

  • getRegistry

@substrate/txwrapper-core

  • getRegistryBase

@substrate/txwrapper-registry

  • getRegistry

@TarikGul TarikGul requested a review from a team as a code owner May 4, 2023 00:47
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TarikGul TarikGul merged commit 671a2d1 into main May 5, 2023
@TarikGul TarikGul deleted the tarik-bundle branch May 5, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject type bundles to support creating transactions for different parachains
2 participants