-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does db snapshots work for cumulus collators? #671
Comments
Hi @samelamin, thanks for reporting this issue and provide feedback. I think the simplest solution is to match the |
No worries @pepoviola I have sent a pr so feel free to review it when you get a chance. Wouldnt it be simpler to extract both at the root? because otherwise you need to match the node role as well as prepare the snapshot differently for both relay and parachain. While if we extract at the root, everything remains consistent? |
Hi @samelamin, thanks for the pr. I would review and check it asap. cc: @michalkucharczyk if we change this we will need to update the CI test for substrate. |
Hi @samelamin, closing here since the pr is already merged and included in the latest version. |
Looking at the code it seems like snapshots cannot be supported because we are writing the snapshot file to the
chains
dir but for collators, we also have therelay-data
directory. A snapshot for a parachain needs both directorieshttps://github.com/paritytech/zombienet/blob/HEAD/javascript/packages/orchestrator/src/providers/native/nativeClient.ts#L283-L284
https://github1s.com/paritytech/zombienet/blob/HEAD/javascript/packages/orchestrator/src/providers/podman/podmanClient.ts#L383-L384
The text was updated successfully, but these errors were encountered: