Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample schema and input data are not consistent #41

Closed
dmartinol opened this issue Mar 26, 2024 · 0 comments
Closed

Sample schema and input data are not consistent #41

dmartinol opened this issue Mar 26, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dmartinol
Copy link
Contributor

  1. The sample data input.json
    is missing the outer onboarding__sub_schema__sample_data.json field. Probably we ca simplify the name to this fields to just subschema or a shorter name: this name resembling the subschema file name could be misleading.

  2. Also, the name of the requested property is sampleText, not someText.

FYI @masayag @anludke
@dmartinol dmartinol added the bug Something isn't working label Mar 26, 2024
@masayag masayag closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@masayag @dmartinol