Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not drop force feedback packets #2

Closed
paroj opened this issue Jun 30, 2015 · 6 comments
Closed

do not drop force feedback packets #2

paroj opened this issue Jun 30, 2015 · 6 comments

Comments

@paroj
Copy link
Owner

paroj commented Jun 30, 2015

while the URB ffff88020d047d80 submitted while active issue is fixed in master, FFB packets might still be dropped.
Consider this patch for SteamOS.

However I first need a way to reproduce this. Using fftest is not enough to triggering the error.

@Hietamaki
Copy link

@paroj
Copy link
Owner Author

paroj commented Jul 26, 2015

yes, related. but the linked patch is a better solution.

@paroj
Copy link
Owner Author

paroj commented Sep 5, 2015

according to dtor one should not use a queue. makes sense.
http://www.spinics.net/lists/linux-input/msg40708.html

@paroj
Copy link
Owner Author

paroj commented Sep 5, 2015

and this is a test for reproducing the race:

while true; do
        for i in $(seq 0 5); do
                echo $i > /sys/class/leds/xpad0/subsystem/xpad0/brightness
        done
done

@paroj
Copy link
Owner Author

paroj commented Sep 27, 2015

re-submitting logic is now in master: 906c1f1.
verified that LED commands get correctly re-submitted.
Still need a test for FF commands. Otherwise done.

@paroj
Copy link
Owner Author

paroj commented Oct 1, 2015

actually this particular problem is fixed. the next one is in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants