Skip to content

Commit 8826d4f

Browse files
mtrezzaJawnnypoo
andauthored
fix wrong appVersion (#1032)
* added appBuild to installation properties * changing appVersion to contain app build instead of version name * added change log breaking change entry * fixed wrong PR link in change log Co-authored-by: John Carlson <jawnnypoo@gmail.com>
1 parent e06b2aa commit 8826d4f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

parse/src/main/java/com/parse/ParseInstallation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ private void updateVersionInfo() {
209209
String packageName = context.getPackageName();
210210
PackageManager pm = context.getPackageManager();
211211
PackageInfo pkgInfo = pm.getPackageInfo(packageName, 0);
212-
String appVersion = pkgInfo.versionName;
212+
String appVersion = String.valueOf(pkgInfo.versionCode);
213213
String appName = pm.getApplicationLabel(pm.getApplicationInfo(packageName, 0)).toString();
214214

215215
if (packageName != null && !packageName.equals(get(KEY_APP_IDENTIFIER))) {

parse/src/test/java/com/parse/ParseInstallationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ public void testUpdateBeforeSave() throws Exception {
289289
String packageName = context.getPackageName();
290290
PackageManager pm = context.getPackageManager();
291291
PackageInfo pkgInfo = pm.getPackageInfo(packageName, 0);
292-
String appVersion = pkgInfo.versionName;
292+
String appVersion = String.valueOf(pkgInfo.versionCode);
293293
String appName = pm.getApplicationLabel(pm.getApplicationInfo(packageName, 0)).toString();
294294
assertEquals(packageName, installation.getString(KEY_APP_IDENTIFIER));
295295
assertEquals(appName, installation.getString(KEY_APP_NAME));

0 commit comments

Comments
 (0)