-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing pending intents mutability for Android 12+ #1139
fix: missing pending intents mutability for Android 12+ #1139
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
============================================
+ Coverage 65.30% 66.11% +0.80%
- Complexity 2218 2241 +23
============================================
Files 122 122
Lines 9961 9965 +4
Branches 1338 1339 +1
============================================
+ Hits 6505 6588 +83
+ Misses 2943 2860 -83
- Partials 513 517 +4
Continue to review full report at Codecov.
|
@mtrezza I cannot understand the failing CI/CD task. This PR should be done. |
The CI fails because this PR decreases code coverage. We require PRs to at least cover their own added code. |
@mtrezza I have add some tests for building the notifications but and I patched the ParseCommandCache as there ware some null pointer exceptions when there's no internet permissions on the tests. Please ignore if possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
## [2.0.6](2.0.5...2.0.6) (2021-11-16) ### Bug Fixes * missing pending intents mutability for Android 12+ ([#1139](#1139)) ([fbe8d87](fbe8d87))
🎉 This change has been released in version 2.0.6 |
New Pull Request Checklist
Issue Description
Pending intents mutability
If your app targets Android 12, you must specify the mutability of each PendingIntent object that your app creates. This additional requirement improves your app's security.
https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability
Related issue: #1137
Closes #1137
Approach
Freeze version of the compile and target to the newest version 31 and on Android 12 versions set PendingIntent immutability flags when receiving Parse notifications.
TODOs before merging
Add testsAdd changes to documentation (guides, repository pages, in-code descriptions)