feat: Add comment to MongoDB query via `Parse.Query.comment` #2088

Meglali20 · 2024-02-19T16:29:42Z

SDK changes for : parse-community/parse-server#8799

parse-github-assistant · 2024-02-19T16:29:46Z

Thanks for opening this pull request!

❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

mtrezza · 2024-03-03T01:36:00Z

CI fails with:

Parse Query can query and send a comment

Error: Invalid parameter for query: comment

I believe the tests are not running with the latest alpha version of Parse Server because the package-lock file usually specifies a commit hash so it's locked to a specific version. Running npm i -DE parse-server@7.0.0-alpha.23 should fix that. However, there's #1979 which we should fix in the coming days, so some tests may fail that are unrelated to this PR.

Meglali20 · 2024-03-04T16:41:17Z

Yes, I was expecting this error. for me, all tests passed when I used parse server as local package after making changes locally related to parse-community/parse-server#8928

mtrezza · 2024-03-05T07:50:44Z

Could you upgrade Parse Server like I've mentioned?

…Parse-SDK-JS into add-comment-to-query-

mtrezza · 2024-03-09T15:12:43Z

There has been some issue with the package-lock file; I've reverted it and ran npm i -DE parse-server@7.0.0-alpha.25.

mtrezza · 2024-03-09T15:40:39Z

I believe we need to upgrade the Parse JS SDK to support only Node 18 and 20, the same node versions as Parse Server 7. In a separate PR, before we can merge this PR. #2063

mtrezza · 2024-03-09T16:31:44Z

Tests are failing because the Parse JS SDK test suite needs to be updated for Parse Server 7. For example, allowClientClassCreation needs to be set to true. #1979

Meglali20 · 2024-03-09T21:25:22Z

When running tests locally most of them pass, did you figure out the issue for this?

mtrezza · 2024-03-10T00:28:43Z

Did you download the latest commit of this branch? I would be surprised if it passed locally. They likely pass when testing with an older version of Parse Server, but not with the latest alpha version as in this branch.

Meglali20 · 2024-03-10T10:01:42Z

You're correct tests are failing, didn't notice you changed to alpha 25 I had to run npm i -DE parse-server@7.0.0-alpha.25 after that tests started failing.

mtrezza · 2024-03-10T13:27:26Z

Yes, I recommend to pull the latest commit in this PR to your local clone, so that you use the same code, delete your current node_modules directory, then run just npm i. Otherwise you may see different errors.

codecov · 2024-03-10T14:50:10Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (86600bc) to head (bc08c7f).
Report is 1 commits behind head on alpha.

Additional details and impacted files

@@            Coverage Diff            @@
##             alpha     #2088   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        61           
  Lines         6173      6186   +13     
  Branches      1494      1498    +4     
=========================================
+ Hits          6173      6186   +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mtrezza · 2024-03-10T14:53:24Z

Tests are passing now; could you check the codecov? It seems that the new tests are not testing all lines of the new feature. After that it should be good to merge.

src/ParseQuery.js

mtrezza

Looks good! Codecov is fixed and all tests pass, thanks for the PR!

# [5.0.0-alpha.3](5.0.0-alpha.2...5.0.0-alpha.3) (2024-03-11) ### Features * Add comment to MongoDB query via `Parse.Query.comment` ([#2088](#2088)) ([a970913](a970913))

parseplatformorg · 2024-03-11T18:37:04Z

🎉 This change has been released in version 5.0.0-alpha.3

# [5.0.0-beta.1](4.3.1...5.0.0-beta.1) (2024-03-17) ### Bug Fixes * Calling `Parse.Object.relation.add` multiple times adds only the first object ([#2078](#2078)) ([0f98117](0f98117)) ### Features * Add comment to MongoDB query via `Parse.Query.comment` ([#2088](#2088)) ([a970913](a970913)) * Add compatibility with Parse Server 7 ([#2089](#2089)) ([86600bc](86600bc)) * Add support for Node 20, remove support for Node 14 and 16 ([#2063](#2063)) ([74eb4d5](74eb4d5)) ### BREAKING CHANGES * Parse JS SDK 5 requires Parse Server 7 and is incompatible with Parse Server 6. ([86600bc](86600bc)) * Removes support for Node 14 and 16. ([74eb4d5](74eb4d5))

parseplatformorg · 2024-03-17T02:44:48Z

🎉 This change has been released in version 5.0.0-beta.1

# [5.0.0](4.3.1...5.0.0) (2024-03-17) ### Bug Fixes * Calling `Parse.Object.relation.add` multiple times adds only the first object ([#2078](#2078)) ([0f98117](0f98117)) ### Features * Add comment to MongoDB query via `Parse.Query.comment` ([#2088](#2088)) ([a970913](a970913)) * Add compatibility with Parse Server 7 ([#2089](#2089)) ([86600bc](86600bc)) * Add support for Node 20, remove support for Node 14 and 16 ([#2063](#2063)) ([74eb4d5](74eb4d5)) ### BREAKING CHANGES * Parse JS SDK 5 requires Parse Server 7 and is incompatible with Parse Server 6. ([86600bc](86600bc)) * Removes support for Node 14 and 16. ([74eb4d5](74eb4d5))

parseplatformorg · 2024-03-17T02:55:06Z

🎉 This change has been released in version 5.0.0

…rification * alpha: chore(release): 5.0.0-beta.1 [skip ci] chore(release): 5.0.0-alpha.3 [skip ci] feat: Add comment to MongoDB query via `Parse.Query.comment` (parse-community#2088) chore(release): 5.0.0-alpha.2 [skip ci] feat: Add compatibility with Parse Server 7 (parse-community#2089) chore(release): 5.0.0-alpha.1 [skip ci] feat: Add support for Node 20, remove support for Node 14 and 16 (parse-community#2063) refactor: Upgrade ws from 8.15.1 to 8.16.0 (parse-community#2087) ci: Remove manual caching for `actions/setup-node` (parse-community#2064) chore(release): 4.3.1-alpha.2 [skip ci] fix: Calling `Parse.Object.relation.add` multiple times adds only the first object (parse-community#2078) refactor: Upgrade ws from 8.15.0 to 8.15.1 (parse-community#2074) chore(release): 4.3.1 [skip ci] release

Initial commit to add comment to a query (for mongodb profiler)

7cffe3d

Meglali20 changed the title ~~Initial commit to add comment to a query (for mongodb profiler)~~ Add comment to a query Feb 19, 2024

Merge branch 'alpha' into add-comment-to-query-

186c07e

Meglali20 added 2 commits March 9, 2024 13:31

Changed parse server version to 7.0.0-alpha.23

3f43589

Merge branch 'add-comment-to-query-' of https://github.com/Meglali20/…

81d6e97

…Parse-SDK-JS into add-comment-to-query-

mtrezza changed the title ~~Add comment to a query~~ feat: Add comment to MongoDB query via Parse.Query.comment Mar 9, 2024

update parse server

4c7a0f1

Merge branch 'alpha' into add-comment-to-query-

19079d3

mtrezza added 2 commits March 10, 2024 15:46

revert package files

3c122b9

Merge branch 'alpha' into add-comment-to-query-

b2a2d67

Added missing coverage lines for tests

c666cd1

mtrezza reviewed Mar 10, 2024

View reviewed changes

src/ParseQuery.js Outdated Show resolved Hide resolved

src/ParseQuery.js Outdated Show resolved Hide resolved

simplifying tests

bc08c7f

mtrezza approved these changes Mar 11, 2024

View reviewed changes

mtrezza merged commit a970913 into parse-community:alpha Mar 11, 2024
9 checks passed

parseplatformorg added the state:released-alpha Released as alpha version label Mar 11, 2024

parseplatformorg added the state:released-beta Released as beta version label Mar 17, 2024

parseplatformorg added the state:released Released as stable version label Mar 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add comment to MongoDB query via `Parse.Query.comment` #2088

feat: Add comment to MongoDB query via `Parse.Query.comment` #2088

Meglali20 commented Feb 19, 2024 •

edited by mtrezza

Loading

parse-github-assistant bot commented Feb 19, 2024 •

edited

Loading

mtrezza commented Mar 3, 2024 •

edited

Loading

Meglali20 commented Mar 4, 2024

mtrezza commented Mar 5, 2024

mtrezza commented Mar 9, 2024

mtrezza commented Mar 9, 2024 •

edited

Loading

mtrezza commented Mar 9, 2024 •

edited

Loading

Meglali20 commented Mar 9, 2024

mtrezza commented Mar 10, 2024 •

edited

Loading

Meglali20 commented Mar 10, 2024

mtrezza commented Mar 10, 2024 •

edited

Loading

codecov bot commented Mar 10, 2024 •

edited

Loading

mtrezza commented Mar 10, 2024 •

edited

Loading

mtrezza left a comment

parseplatformorg commented Mar 11, 2024

parseplatformorg commented Mar 17, 2024

parseplatformorg commented Mar 17, 2024

feat: Add comment to MongoDB query via Parse.Query.comment #2088

feat: Add comment to MongoDB query via Parse.Query.comment #2088

Conversation

Meglali20 commented Feb 19, 2024 • edited by mtrezza Loading

parse-github-assistant bot commented Feb 19, 2024 • edited Loading

Thanks for opening this pull request!

mtrezza commented Mar 3, 2024 • edited Loading

Meglali20 commented Mar 4, 2024

mtrezza commented Mar 5, 2024

mtrezza commented Mar 9, 2024

mtrezza commented Mar 9, 2024 • edited Loading

mtrezza commented Mar 9, 2024 • edited Loading

Meglali20 commented Mar 9, 2024

mtrezza commented Mar 10, 2024 • edited Loading

Meglali20 commented Mar 10, 2024

mtrezza commented Mar 10, 2024 • edited Loading

codecov bot commented Mar 10, 2024 • edited Loading

Codecov Report

mtrezza commented Mar 10, 2024 • edited Loading

mtrezza left a comment

Choose a reason for hiding this comment

parseplatformorg commented Mar 11, 2024

parseplatformorg commented Mar 17, 2024

parseplatformorg commented Mar 17, 2024

feat: Add comment to MongoDB query via `Parse.Query.comment` #2088

feat: Add comment to MongoDB query via `Parse.Query.comment` #2088

Meglali20 commented Feb 19, 2024 •

edited by mtrezza

Loading

parse-github-assistant bot commented Feb 19, 2024 •

edited

Loading

mtrezza commented Mar 3, 2024 •

edited

Loading

mtrezza commented Mar 9, 2024 •

edited

Loading

mtrezza commented Mar 9, 2024 •

edited

Loading

mtrezza commented Mar 10, 2024 •

edited

Loading

mtrezza commented Mar 10, 2024 •

edited

Loading

codecov bot commented Mar 10, 2024 •

edited

Loading

mtrezza commented Mar 10, 2024 •

edited

Loading