Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test for Parse.User.verifyPassword option ignoreEmailVerification #2101

Closed
4 tasks done
dplewis opened this issue Apr 12, 2024 · 2 comments
Closed
4 tasks done

Comments

@dplewis
Copy link
Member

dplewis commented Apr 12, 2024

New Issue Checklist

Issue Description

#2076 introduced ignoreEmailVerification option on Parse.User.verifyPassword a unit test is missing. Code coverage has dropped. I was slightly confused when I saw it was added to the payload over the options when passing into the AJAX request.

Steps to reproduce

https://github.com/parse-community/Parse-SDK-JS/blob/5.1.0-alpha.1/src/RESTController.js#L253-L255

Actual Outcome

Test doesn't exist

Expected Outcome

100% code coverage

Environment

Server

  • Parse Server version: 6.1.0
  • Operating system: MacOS
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

Database

  • System (MongoDB or Postgres): Mongo
  • Database version: 6.0.0
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): lcoal

Client

  • Parse JS SDK version: 4.1.0

Logs

Copy link

parse-github-assistant bot commented Apr 12, 2024

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza
Copy link
Member

mtrezza commented Apr 13, 2024

Obsolete thanks to #2107

@mtrezza mtrezza closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants