Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation support for JS SDK #2112

Closed
3 tasks done
mortenmo opened this issue Apr 18, 2024 · 4 comments · Fixed by #2119
Closed
3 tasks done

Installation support for JS SDK #2112

mortenmo opened this issue Apr 18, 2024 · 4 comments · Fixed by #2119
Labels
type:feature New feature or improvement of existing feature

Comments

@mortenmo
Copy link
Contributor

mortenmo commented Apr 18, 2024

New Feature / Enhancement Checklist

Current Limitation

Other Parse SDKs (Swift/Kotlin, etc) supports the Installation object to handle push notifications etc. There seems in the JS SDK there is just a minimal implementation.

  • For React Native/Expo, this is limiting, ideally it should work similar to build a RN app vs Swift/Kotlin.
  • Web browsers also support notifications now, so supporting this in the SDK even for just web might be useful to some users.

Feature / Enhancement Description

Similar to the phone SDKs, handle maintaining the Installation object per installation. Things like device type, tokens etc could be handled in similar ways probably relying on react native libraries for react native at least.

This isn't really asking for new functionality beyond what is available in other SDKs.

Alternatives / Workarounds

You could probably handle this all manually today.

3rd Party References

In the other SDKs built for Mobile.

Copy link

parse-github-assistant bot commented Apr 18, 2024

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Apr 18, 2024
@dplewis
Copy link
Member

dplewis commented Apr 20, 2024

@mortenmo Good idea, getting this working for the web should be easy. For react-native / expo as long as a deviceToken and deviceType are set it should work with Parse.Push out of the box.

@dplewis
Copy link
Member

dplewis commented May 3, 2024

@mortenmo I added Push notification for web support if you want to check it out

parse-community/parse-server-push-adapter#239

@mortenmo
Copy link
Contributor Author

mortenmo commented May 4, 2024

@dplewis nice! looking forward to try it out. I'm using Expo push (https://docs.expo.dev/push-notifications/sending-notifications/) on React Native/Expo for mobile so I'll migrate my custom notification code to use the push adapter there too when this all merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
3 participants