feat: Add Uint8Array support for Parse.File data
#2548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2548 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6238 6238
Branches 1464 1452 -12
=========================================
Hits 6238 6238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtrezza
changed the title
Uint8Array support for Parse.File
mtrezza
changed the title
Uint8Array support for Parse.FileUint8Array support for Parse.File data
parseplatformorg
pushed a commit
that referenced
this pull request
Apr 7, 2025
# [6.2.0-alpha.1](6.1.1...6.2.0-alpha.1) (2025-04-07) ### Features * Add `Uint8Array` support for `Parse.File` data ([#2548](#2548)) ([6f6bb66](6f6bb66))
|
🎉 This change has been released in version 6.2.0-alpha.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Parse.File.encodeBase64 accepts both number[] and Uint8Array but there is no way to pass Uint8Array to Parse.File.
There is also a flaky test #2530. I believe it occurs because those files are so small in size they save before you get a chance to cancel which causes the timeout.
Closes: #2530
Approach
Tasks