Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to edit array of pointers in v2.2.0 #1770

Closed
4 tasks done
johanarnor opened this issue Aug 30, 2021 · 5 comments
Closed
4 tasks done

Impossible to edit array of pointers in v2.2.0 #1770

johanarnor opened this issue Aug 30, 2021 · 5 comments
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@johanarnor
Copy link

New Issue Checklist

Issue Description

In v2.2.0 it's no longer possible to properly edit the value of an array containing pointers. #1727 introduces a click action that overrides the standard in-place edit box.

I therefore tried to edit the data via the modal, but this would instead corrupt the data. The data is displayed like this (which if saved will corrupt the data)

[
  {"objectId": "3EAyCmr7BU"},
  {"objectId": "EAGB5dfkCe"}
]

instead of the actual raw format.

[
  {"__type":"Pointer","className":"Item","objectId":"3EAyCmr7BU"}, 
  {"__type":"Pointer","className":"Item","objectId":"EAGB5dfkCe"},
]

However this issue with the modal wasn't introduced in v2.2.0, since it's present in v2.1.0. Another interesting behaviour is that the whole object will be "inflated" (i.e. all fields will be populated) if you visit that object in the same browser tab prior to trying to edit the array of pointers.

Also, a CTRL+C puts "[object Object]" in the clipboard instead of the actual raw object.

Expected Outcome

I'm not sure what a good solution would be here. Maybe just remove the click action to bring up the original edit box.

I've never used the modal, so I'm not really sure what's the expected outcome here.

@github-actions
Copy link
Contributor

🤖 Parsy

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

I'm in beta, so forgive me if I'm still making mistakes.

@mtrezza
Copy link
Member

mtrezza commented Aug 30, 2021

@sadakchap Could you take a look at this?

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Aug 30, 2021
@sadakchap
Copy link
Member

Sure @mtrezza , Thanks!

@sadakchap sadakchap mentioned this issue Aug 31, 2021
3 tasks
@sadakchap
Copy link
Member

Here's the pr #1771

@mtrezza
Copy link
Member

mtrezza commented Sep 2, 2021

Closing via #1771

@mtrezza mtrezza closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

No branches or pull requests

3 participants