Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File uploading status not changing after uploading completed #2274

Closed
Sarun1001 opened this issue Sep 17, 2022 · 6 comments · Fixed by #2422
Closed

File uploading status not changing after uploading completed #2274

Sarun1001 opened this issue Sep 17, 2022 · 6 comments · Fixed by #2422
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@Sarun1001
Copy link

New Issue Checklist

Issue Description

https://i.ibb.co/JHcYx8D/Screenshot-at-Sept-18-02-15-34.png

  • File uploading status not changing after uploading completed,

When user updates a file in a field it indefinitely shows "uploading..." status but we can see the uploaded file in s3, it should change to "completed" or filename after finishing uploading operation

  • Change label from "uploading..." to filename or "upload pending" or "upload waiting confirmation" or something more convenient before pressing add button

Currently when users select a file from device it's showing "uploading..." label in the selected view but actually, files are not getting uploaded at that point, file uploading only starts when the user press add button, this is a confusing implementation users waits for this 'uploading...' label to change to something like 'completed', it's a bad UX

Steps to reproduce

  • Update a file in dashboard

  • Select a file to upload in dashboard

Actual Outcome

"Uploading..." status inside view keeps displaying even after the upload is completed
Showing "Uploading..." before pressing add button

Expected Outcome

  • "Uploading..." status should change to "complete" or filename when uploading operation finishes

  • Show "Uploading..." only after pressing add button, before that provide appropriate label

Environment

Dashboard

  • Parse Dashboard version: 4.1.4
  • Browser (Safari, Chrome, Firefox, Edge, etc.): Chrome
  • Browser version: 105.0.5195.125 (Official Build) (x86_64)

Server

  • Parse Server version: 5.2.5
  • Operating system: Ubuntu 22.04.1 LTS
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): remote-AWS

Database

  • System (MongoDB or Postgres): MongoDB
  • Database version: 5.0.12
  • Node version v18.1.0
  • FileAdapter - s3 (aws)
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): AWS

Logs

No logs or error messages on the browser

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 17, 2022

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza changed the title File uploading status not changing after uploading completed (When updating) & Change label from "uploading..." to filename or "upload pending" or something more convenient before pressing add button File uploading status not changing after uploading completed Sep 17, 2022
@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Sep 17, 2022
@patelmilanun
Copy link
Member

i found the exact issue but not sure if the solution I have is correct or not

if (this.props.value !== prevProps.value) {
  this.renderCellContent();
  this.props.value._previousSave
    ?.then(res => this.renderCellContent())
    ?.catch(err => console.log(err))
}

we need to add this to parse-dashboard\src\components\BrowserCell\BrowserCell.react.js inside componentDidUpdate

@mtrezza can u help!

@mtrezza
Copy link
Member

mtrezza commented Apr 9, 2023

You could just open a PR and others (including yourself) can test if that works with the automatic dev deployment in the PR.

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label May 27, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants