Skip to content

Commit

Permalink
fix: Pass customObjectId in beforeSave (#7167)
Browse files Browse the repository at this point in the history
* beforeSave custom object id fix

* Added regression test case for issue #6733
  • Loading branch information
mstniy authored Feb 12, 2021
1 parent 72cf31a commit 7224cde
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 0 deletions.
33 changes: 33 additions & 0 deletions spec/CloudCode.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1779,6 +1779,39 @@ describe('beforeSave hooks', () => {
const myObject = new MyObject();
myObject.save().then(() => done());
});

it('should respect custom object ids (#6733)', async () => {
Parse.Cloud.beforeSave('TestObject', req => {
expect(req.object.id).toEqual('test_6733');
});

await reconfigureServer({ allowCustomObjectId: true });

const req = request({
// Parse JS SDK does not currently support custom object ids (see #1097), so we do a REST request
method: 'POST',
url: 'http://localhost:8378/1/classes/TestObject',
headers: {
'X-Parse-Application-Id': 'test',
'X-Parse-REST-API-Key': 'rest',
},
body: {
objectId: 'test_6733',
foo: 'bar',
},
});

{
const res = await req;
expect(res.data.objectId).toEqual('test_6733');
}

const query = new Parse.Query('TestObject');
query.equalTo('objectId', 'test_6733');
const res = await query.find();
expect(res.length).toEqual(1);
expect(res[0].get('foo')).toEqual('bar');
});
});

describe('afterSave hooks', () => {
Expand Down
1 change: 1 addition & 0 deletions src/triggers.js
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ export function getResponseObject(request, resolve, reject) {
response = {};
if (request.triggerName === Types.beforeSave) {
response['object'] = request.object._getSaveJSON();
response['object']['objectId'] = request.object.id;
}
return resolve(response);
},
Expand Down

0 comments on commit 7224cde

Please sign in to comment.