Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canAddField does not respect master key #1257

Closed
anatolydwnld opened this issue Mar 29, 2016 · 2 comments · Fixed by #1291
Closed

canAddField does not respect master key #1257

anatolydwnld opened this issue Mar 29, 2016 · 2 comments · Fixed by #1291
Assignees
@flovilmart
Labels
type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@anatolydwnld
Copy link

DatabaseController.canAddField does not check whether a request is issued with a master key before verifying CLPs. This is not consistent with all other DB ops(create/update/read/delete). Is it this way by design?
@flovilmart
Copy link
Contributor

Is this causing a problem?

@anatolydwnld
Copy link
Author

It causes 404s with "operation not permitted" on writes with the master key, which was surprising and difficult to debug.

@drew-gross drew-gross added the type:bug Impaired feature or lacking behavior that is likely assumed label Mar 29, 2016
@flovilmart flovilmart self-assigned this Mar 30, 2016
@flovilmart flovilmart mentioned this issue Mar 31, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flovilmart flovilmart

Labels
type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly let masterKey add fields parse-community/parse-server
3 participants
@flovilmart @drew-gross @anatolydwnld