Skip to content

Fix flaky ACL tests #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drew-gross opened this issue Feb 8, 2016 · 3 comments
Closed

Fix flaky ACL tests #293

drew-gross opened this issue Feb 8, 2016 · 3 comments

Comments

@drew-gross
Copy link
Contributor

In https://travis-ci.org/ParsePlatform/parse-server/jobs/107590068 there were some tests that failed. Step one in debugging would probably be to add some fail() calls to the tests, as the amount of information currently being output isn't very much help.

@gnz00
Copy link

gnz00 commented Feb 8, 2016

Seems that they've just timed out; we're overriding the default timeout in Jasmine from 5 seconds to 2 seconds. Since it's flickering, I'm inclined to believe it's network / resource related in the Travis CI environment. I'd be curious to see how often this can be reproduced and if it can be reproduced at all using the default Jasmine timeout of 5 seconds.

@drew-gross
Copy link
Contributor Author

Thats possible but the code in the test seems very simple, with very few database accesses. I wouldn't expect it to be timing out randomly.

@gfosco
Copy link
Contributor

gfosco commented Feb 26, 2016

Closing this, don't think we've had any flaky acl failures in a while..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants