Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove: skipMongoDBServer13732Workaround #6444

Closed
acinader opened this issue Feb 26, 2020 · 2 comments · Fixed by #6445
Closed

Remove: skipMongoDBServer13732Workaround #6444

acinader opened this issue Feb 26, 2020 · 2 comments · Fixed by #6445

Comments

@acinader
Copy link
Contributor

parse-server 4.0 will set a new min mongodb version of 3.6 making the MongoDBServer13732Workaround no longer needed.

I will switch skipMongoDBServer13732Workaround to default to false for the sake of expediency, but it would bee nice to remove all of the code.

see: #5617

any interest @NotBobTheBuilder :) ?
@acinader acinader mentioned this issue Feb 27, 2020
Merged
@NotBobTheBuilder
Copy link
Contributor

Great stuff. I can definitely file a PR to remove all the logic, hopefully next week. Looks like I should just file that against master when #6445 is merged?

I think that flag can be permanently true now, since 3.6+ can handle the unmodified queries that hit that bug. Thanks for the ping! :)

@acinader
Copy link
Contributor Author

I think I stole your thunder and just did it. Can you take a look at #6445 and see if there's anything I missed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set min mongodb to 3.6 in prep for parse-server 4.0 parse-community/parse-server
2 participants
@acinader @NotBobTheBuilder