Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(directAccess/cloud-code): Pass installationId with LogIn #6903

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Sep 12, 2020

InstallationId didn't get passed correctly. Resulting in _Session without installationId

https://github.com/parse-community/parse-server/blob/master/src/Routers/UsersRouter.js#L263

  • Fixed error with POST /login and req.query is undefined

Let me know if more tests are needed.

InstallationId didn't get passed correctly. Resulting in _Session without installationId

https://github.com/parse-community/parse-server/blob/master/src/Routers/UsersRouter.js#L263

* Fixed error with POST /login and req.query is undefined
@dplewis dplewis mentioned this pull request Sep 12, 2020
6 tasks
@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #6903 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6903      +/-   ##
==========================================
- Coverage   93.83%   93.81%   -0.03%     
==========================================
  Files         169      169              
  Lines       12220    12220              
==========================================
- Hits        11467    11464       -3     
- Misses        753      756       +3     
Impacted Files Coverage Δ
src/ParseServerRESTController.js 98.18% <ø> (ø)
src/Routers/UsersRouter.js 94.37% <ø> (ø)
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.92% <0.00%> (-0.67%) ⬇️
src/RestWrite.js 93.98% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53853c...5b595cf. Read the comment docs.

Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dplewis dplewis merged commit 1246c90 into master Sep 17, 2020
@dplewis dplewis deleted the directAccess-installationid branch September 17, 2020 16:53
TylerBrock pushed a commit to Hustle/parse-server that referenced this pull request Sep 22, 2020
…ommunity#6903)

InstallationId didn't get passed correctly. Resulting in _Session without installationId

https://github.com/parse-community/parse-server/blob/master/src/Routers/UsersRouter.js#L263

* Fixed error with POST /login and req.query is undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants