Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jobs): Add Error Message to JobStatus Failure #6954

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 20, 2020

Previously only supported promise rejections. This will support Errors and Parse.Errors.
Useful for debugging why jobs failed.

Screen Shot 2020-10-20 at 3 54 07 PM

https://github.com/parse-community/parse-server/compare/job-error-fix?expand=1#diff-4b307fc6c944735404b819d07f4d514564d5f624f0f190df784c63067c483ab9R131

@ghost
Copy link

ghost commented Oct 20, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #6954 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6954      +/-   ##
==========================================
- Coverage   93.79%   93.78%   -0.02%     
==========================================
  Files         169      169              
  Lines       12252    12254       +2     
==========================================
  Hits        11492    11492              
- Misses        760      762       +2     
Impacted Files Coverage Δ
src/StatusHandler.js 99.27% <100.00%> (+0.01%) ⬆️
src/RestWrite.js 93.65% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 135569c...730aa0f. Read the comment docs.

@dplewis dplewis requested review from mtrezza and davimacedo October 20, 2020 21:41
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit 72428dc into master Oct 20, 2020
@dplewis dplewis deleted the job-error-fix branch October 20, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants