Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parameter in Cloud Function #6969

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Remove unused parameter in Cloud Function #6969

merged 2 commits into from
Oct 26, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Oct 24, 2020

Parse.Cloud.define('MyClass', (request, message) => {})

Useful for users who haven't migrated and still use response parameter.

Looks like it mixed up with the Jobs implementation. job has request.message()

@ghost
Copy link

ghost commented Oct 24, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #6969 into master will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6969      +/-   ##
==========================================
+ Coverage   93.87%   94.26%   +0.39%     
==========================================
  Files         169      169              
  Lines       12370    15918    +3548     
==========================================
+ Hits        11612    15005    +3393     
- Misses        758      913     +155     
Impacted Files Coverage Δ
src/Routers/FunctionsRouter.js 95.41% <100.00%> (+1.29%) ⬆️
src/Routers/SessionsRouter.js 78.72% <0.00%> (-12.46%) ⬇️
src/ParseMessageQueue.js 78.94% <0.00%> (-5.67%) ⬇️
src/Adapters/Auth/httpsRequest.js 95.23% <0.00%> (-4.77%) ⬇️
src/Auth.js 95.75% <0.00%> (-4.25%) ⬇️
src/Routers/AggregateRouter.js 96.00% <0.00%> (-4.00%) ⬇️
src/LiveQuery/ParsePubSub.js 88.00% <0.00%> (-2.00%) ⬇️
src/middlewares.js 95.63% <0.00%> (-1.55%) ⬇️
src/AccountLockout.js 96.22% <0.00%> (-1.15%) ⬇️
src/Routers/PushRouter.js 95.74% <0.00%> (-0.81%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f2281...a8b9871. Read the comment docs.

@mtrezza
Copy link
Member

mtrezza commented Oct 25, 2020

Useful for users who haven't migrated and still use response parameter.
Looks like it mixed up with the Jobs implementation. job has request.message()

This PR removes the message parameter from CC function, right? Where did that come from? Does that not solve any purpose or could that be a breaking change for some?

@dplewis
Copy link
Member Author

dplewis commented Oct 25, 2020

Where did that come from?

The second parameter should have been totally removed after the 3.0.0 update. It serves no purpose right now and the message parameter returns { message: undefined } always.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dplewis dplewis merged commit 74ba811 into master Oct 26, 2020
@dplewis dplewis deleted the cloud-message branch October 26, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants