-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused parameter in Cloud Function #6969
Conversation
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #6969 +/- ##
==========================================
+ Coverage 93.87% 94.26% +0.39%
==========================================
Files 169 169
Lines 12370 15918 +3548
==========================================
+ Hits 11612 15005 +3393
- Misses 758 913 +155
Continue to review full report at Codecov.
|
This PR removes the message parameter from CC function, right? Where did that come from? Does that not solve any purpose or could that be a breaking change for some? |
The second parameter should have been totally removed after the 3.0.0 update. It serves no purpose right now and the message parameter returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Parse.Cloud.define('MyClass', (request, message) => {})
Useful for users who haven't migrated and still use response parameter.
Looks like it mixed up with the Jobs implementation. job has
request.message()